Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mathematical mistake in the progress bar drawing #7317

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix mathematical mistake in the progress bar drawing #7317

merged 1 commit into from
Mar 13, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Mar 13, 2023 •
edited
Loading

This PR fixes #7316

The actual fix is the following change (the rest is cosmetic refactoring and could be extracted to a separate PR by request):

from:

qt_color.setHsl(26, 255, 128 + int(127 * (1 - piece_sum // pieces_per_pixel)))

to:

qt_color.setHsl(26, 255, 128 + int(127 * (1 - piece_sum / pieces_per_pixel)))

image

@drew2a drew2a marked this pull request as ready for review March 13, 2023 13:55
@drew2a drew2a requested review from a team and xoriole and removed request for a team March 13, 2023 13:55
@drew2a drew2a merged commit 0fb30d3 into Tribler:main Mar 13, 2023
@drew2a drew2a deleted the fix/7316 branch March 13, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoriole xoriole xoriole approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The download indicator (details tab) is broken
2 participants
@drew2a @xoriole